Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrations always running regardless of enabled flag #689

Merged
merged 17 commits into from
Jul 21, 2021
Merged

Integrations always running regardless of enabled flag #689

merged 17 commits into from
Jul 21, 2021

Commits on Jun 25, 2021

  1. Enabled flag should drive collection

    @mattdurham
    mattdurham committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    c9e476b View commit details
    Browse the repository at this point in the history

  2. Satisfy linter

    @mattdurham
    mattdurham committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    afa2eee View commit details
    Browse the repository at this point in the history

  3. Fix mock integration so it sets enabled = true by default

    @mattdurham
    mattdurham committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    cce8999 View commit details
    Browse the repository at this point in the history

  4. Make enabled the equivalent of not being in the config, removing it a… 

    …t the config reloader so that it propagates from the source downstream
    @mattdurham
    mattdurham committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    6808da7 View commit details
    Browse the repository at this point in the history

  5. Fix issue where removing the config/disabling did NOT stop the scraper

    @mattdurham
    mattdurham committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    22f1d16 View commit details
    Browse the repository at this point in the history

  6. Remove whitespace

    @mattdurham
    mattdurham committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    cd058b4 View commit details
    Browse the repository at this point in the history

  7. remove unneeded comment

    @mattdurham
    mattdurham committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    e7b90a7 View commit details
    Browse the repository at this point in the history

  8. Remove duplicated delete config

    @mattdurham
    mattdurham committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    0f9ca9c View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2021

  1. Update comments and add unit tests. Also had to fix mock integration … 

    …so that it generated yaml.
    @mattdurham
    mattdurham committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    bb362da View commit details
    Browse the repository at this point in the history

  2. Simplify unit test

    @mattdurham
    mattdurham committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    d752a4f View commit details
    Browse the repository at this point in the history

  3. change case because of refactor

    @mattdurham
    mattdurham committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    b7f0e68 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/main' into enabled_issue

    @mattdurham
    mattdurham committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    a60942a View commit details
    Browse the repository at this point in the history

  5. filter integrations to enabled set

    @rfratto
    rfratto committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    98895c0 View commit details
    Browse the repository at this point in the history

  6. Move check up to the first statement

    @mattdurham
    mattdurham committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    8c4c896 View commit details
    Browse the repository at this point in the history

  7. merge

    @mattdurham
    mattdurham committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    f90f44a View commit details
    Browse the repository at this point in the history

  8. fix merge

    @mattdurham
    mattdurham committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    7b1987f View commit details
    Browse the repository at this point in the history

  9. Fix for double loop

    @mattdurham
    mattdurham committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    411ccde View commit details
    Browse the repository at this point in the history