add APIURL to telegram config #168
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| @@ -71,5 +72,8 @@ func NewConfig(jsonData json.RawMessage, decryptFn receivers.DecryptFunc) (Confi | |||
| if !found { | |||
| return settings, fmt.Errorf("unknown parse_mode, must be Markdown, MarkdownV2, HTML or None") | |||
| } | |||
| if settings.APIURL == "" { | |||
| settings.APIURL = APIURL | |||
There was a problem hiding this comment.
am i blind, but where is APIURL variable? Did you mean defaultAPIURL or something like that?
|
Sorry for the inconvenience. It is a work-in-progress pull request(I mark this now). I didn't find any time to complete this and related pr in the main project for this feature. (I was working on it in the yearly Nowruz vacations. So maybe I will complete this on the next vacation in March) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix is part of fix for grafana/grafana#81534