Support HMAC SHA256 request signing in the http client #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akhmetov
force-pushed
the
alexander-akhmetov/hmac
branch
from
51de65e to
97ccdd1
Compare
alexander-akhmetov
force-pushed
the
alexander-akhmetov/hmac
branch
from
97ccdd1 to
41f2890
Compare
3 tasks
alexander-akhmetov
force-pushed
the
alexander-akhmetov/hmac
branch
from
41f2890 to
95e4311
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds optional HMAC SHA256 signing to the HTTP client.
A new HMACRoundTripper (in http/hmac.go) computes and adds a signature for outgoing webhooks. The signature is computed from the request body.
Optionally, a timestamp header name can be specified, and if it's set, the signature is computed from
{timestamp}:{body}, and the timestamp is added to the headers for the client to verify.Other implementation examples:
Draft PR to Grafana: grafana/grafana#100960 if you want to test it locally.
Part of https://github.com/grafana/alerting-squad/issues/1040