-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an otelcol.exporter.kafka component #717
Conversation
I wonder if we still need to implement an equivalent otelcol-to-Alloy converter, similar to these? 🤔 |
b40405e
to
ebc2dda
Compare
Something that is worth looking at is whether or not the fix exists in Grafana Alloy so sasl mechanism AWS_MSK_IAM actually works. Please look at this issue: open-telemetry/opentelemetry-collector-contrib#32500 |
613aefb
to
674a729
Compare
@hainenber True, I added the converters now :) @mattiasnensen Unfortunately I think Alloy will only pick up the change once the upstream exporter has implemented it. If you need to reach out to the Otel maintainers you could open an issue in the Contrib repo or send a message on the CNCF slack. As a last resort you could also just open another PR which is inspired by the closed one that you are interested in. The Alloy team also contributes upstream, but in this case it doesn't seem to be a critical issue and more of a missing feature? In that case I honestly don't think we'd have bandwidth for it, since we're a bit preoccupied with more urgent work :/ |
It was reported here but it was closed: open-telemetry/opentelemetry-collector-contrib#19747 Then this issue was created which allegedly fixed the issue, but the contribution wasn't accepted as the contributor didn't have a signed CLA: open-telemetry/opentelemetry-collector-contrib#32500 Best regards, |
internal/converter/internal/otelcolconvert/converter_kafkaexporter.go
Outdated
Show resolved
Hide resolved
One additional comment: can you update the link to the otel component in your PR please? It points to the v0.96.0 version but the one implemented here is the v0.101.0 |
Co-authored-by: William Dumont <william.dumont@grafana.com>
b6c3855
to
37f3eb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
37f3eb9
to
772d9ab
Compare
docs/sources/shared/reference/components/otelcol-kafka-authentication-plaintext.md
Outdated
Show resolved
Hide resolved
docs/sources/shared/reference/components/otelcol-kafka-authentication-kerberos.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs look OK to me :-)
Looks good. I know the descriptions in the shared content are unlikely to be seen anywhere, but... good habit to be consistent if we can and you never know what search results will show up. |
PR Description
Adding a new
otelcol.exporter.kafka
component based on the OTel Collector's kafka exporter.Which issue(s) this PR fixes
Fixes #290
PR Checklist