add CRUD handlers for user notification rules + remove custom actions endpoint handlers #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyorlando
changed the title
joeyorlando
commented
Jun 19, 2024
mderynck
approved these changes
Jun 19, 2024
joeyorlando
deleted the
jorlando/add-oncall-user-notification-policy-resource
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for grafana/terraform-provider-grafana#1653
Related to grafana/oncall#4410
"Custom Actions"
This functionality has long been removed from Grafana OnCall (and migrated to Outgoing Webhooks). These endpoints are not referenced anywhere in
grafana/terraform-provider-grafana(code search). Removing this should only affect the latest published version of thegit.luolix.top/grafana/amixr-api-go-clientGo package (grafana/terraform-provider-grafana#1653 will also bump to this latest version to take advantage of these new user notification rule client methods).