Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update clickhouse-go to v2.4.3 #255

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Update clickhouse-go to v2.4.3 #255

merged 1 commit into from
Dec 13, 2022

Conversation

jkaflik
Copy link
Collaborator

@jkaflik jkaflik commented Dec 7, 2022

Resolves #231
Resolves #215

@CLAassistant
Copy link

CLAassistant commented Dec 7, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mshustov
Copy link
Collaborator

mshustov commented Dec 9, 2022

cc @scottlepp @bossinc

@cletter7
Copy link
Contributor

cletter7 commented Dec 9, 2022

@jkaflik please run go mod tidy to remove unnecessary entries from go.sum

@jkaflik
Copy link
Collaborator Author

jkaflik commented Dec 9, 2022

@cletter7 yes. thanks.

cletter7
cletter7 suggested changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@cletter7 cletter7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could you please update from main @jkaflik? Currently there are conflicts because of recent changes.

@jkaflik jkaflik force-pushed the clickhouse-go/v2-2.4.3 branch from 6307b54 to 94d49af Compare December 9, 2022 15:31
@jkaflik jkaflik requested a review from cletter7 December 9, 2022 16:10
@bossinc bossinc merged commit 75360c4 into grafana:main Dec 13, 2022
@jkaflik jkaflik mentioned this pull request Dec 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottlepp scottlepp scottlepp approved these changes

@cletter7 cletter7 Awaiting requested review from cletter7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plugin health check failed HTTP Connection not working for CH Server below 21.4
6 participants
@jkaflik @CLAassistant @mshustov @cletter7 @scottlepp @bossinc