Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsdb: Add multi concurrency and max idle connections store gateway params #414

Merged
merged 4 commits into from
Nov 2, 2021
Merged

tsdb: Add multi concurrency and max idle connections store gateway params #414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
88fa66f
tsdb: Add multi concurrency and max idle connections store gateway pa…
aknuds1 Nov 2, 2021
d71384d
Update cortex/tsdb.libsonnet
aknuds1 Nov 2, 2021
e751ecc
Fix formatting
aknuds1 Nov 2, 2021
92d7684
tsdb: Use literal numbers instead of variables
aknuds1 Nov 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

## master / unreleased

* [CHANGE] Store gateway: set `-blocks-storage.bucket-store.index-cache.memcached.max-get-multi-concurrency`,
`-blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency`,
`-blocks-storage.bucket-store.metadata-cache.memcached.max-get-multi-concurrency`,
`-blocks-storage.bucket-store.index-cache.memcached.max-idle-connections`,
`-blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections`,
`-blocks-storage.bucket-store.metadata-cache.memcached.max-idle-connections` to 100 #414
* [CHANGE] Update grafana-builder dependency: use $__rate_interval in qpsPanel and latencyPanel. #372
* [CHANGE] `namespace` template variable in dashboards now only selects namespaces for selected clusters. #311
* [CHANGE] Alertmanager: mounted overrides configmap to alertmanager too. #315
Expand Down
14 changes: 14 additions & 0 deletions cortex/tsdb.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,20 @@
'blocks-storage.bucket-store.index-header-lazy-loading-idle-timeout': '60m',

'blocks-storage.bucket-store.max-chunk-pool-bytes': 12 * 1024 * 1024 * 1024,

// We should keep a number of idle connections equal to the max "get" concurrency,
// in order to avoid re-opening connections continuously (this would be slower
// and fill up the conntrack table too).
//
// The downside of this approach is that we'll end up with an higher number of
// active connections to memcached, so we have to make sure connections limit
// set in memcached is high enough.
'blocks-storage.bucket-store.index-cache.memcached.max-get-multi-concurrency': 100,
'blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency': 100,
'blocks-storage.bucket-store.metadata-cache.memcached.max-get-multi-concurrency': 100,
'blocks-storage.bucket-store.index-cache.memcached.max-idle-connections': $.store_gateway_args['blocks-storage.bucket-store.index-cache.memcached.max-get-multi-concurrency'],
'blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections': $.store_gateway_args['blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency'],
'blocks-storage.bucket-store.metadata-cache.memcached.max-idle-connections': $.store_gateway_args['blocks-storage.bucket-store.metadata-cache.memcached.max-get-multi-concurrency'],
} +
$.blocks_chunks_caching_config +
$.blocks_metadata_caching_config +
Expand Down