benchtool: avoid registering DNS metrics twice (#188)

grafana · Jun 5, 2021 · 4c91805 · 4c91805
1 parent f2fb4f8
commit 4c91805
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@ Order should be `CHANGE`, `FEATURE`, `ENHANCEMENT`, and `BUGFIX`
 
 ## unreleased/master
 
+* [BUGFIX] Benchtool: avoid duplicate DNS metrics registration when enabling both query and write benchmarking. #188
 * [ENHANCEMENT] Added the ability to set an explicit user when Cortex is behind basic auth. #187
 
 ## v0.10.1

diff --git a/pkg/bench/query_runner.go b/pkg/bench/query_runner.go
@@ -64,7 +64,7 @@ func newQueryRunner(id string, tenantName string, cfg QueryConfig, workload *que
 		clientPool: map[string]v1.API{},
 		dnsProvider: dns.NewProvider(
 			logger,
-			extprom.WrapRegistererWithPrefix("benchtool_", reg),
+			extprom.WrapRegistererWithPrefix("benchtool_query_", reg),
 			dns.GolangResolverType,
 		),
 

diff --git a/pkg/bench/write_runner.go b/pkg/bench/write_runner.go
@@ -67,7 +67,7 @@ func NewWriteBenchmarkRunner(id string, tenantName string, cfg WriteBenchConfig,
 		workload: workload,
 		dnsProvider: dns.NewProvider(
 			logger,
-			extprom.WrapRegistererWithPrefix("benchtool_", reg),
+			extprom.WrapRegistererWithPrefix("benchtool_write_", reg),
 			dns.GolangResolverType,
 		),
 		clientPool: map[string]*writeClient{},