Skip to content

Commit

Permalink
chore(*): Auto-linting + Node v22 requirement (#337)
Browse files Browse the repository at this point in the history
  • Loading branch information
grafakus authored Jan 20, 2025
1 parent 8b89010 commit 5b6e9bd
Show file tree
Hide file tree
Showing 7 changed files with 314 additions and 314 deletions.
16 changes: 8 additions & 8 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ jobs:
# When pushed to main it uses "gcs-no-approval" environment which can be triggered only from main
# to push the package automatically without approval
name: Package and publish plugin
needs: [ frontend ]
needs: [frontend]
environment: ${{ github.event_name == 'push' && 'gcs-no-approval' || 'gcs' }}
runs-on: ubuntu-latest
outputs:
Expand All @@ -164,7 +164,7 @@ jobs:
id: metadata
run: |
sudo apt-get install jq
export GRAFANA_PLUGIN_ID=$(cat dist/plugin.json | jq -r .id)
export SHA=${{ github.event.pull_request.head.sha || github.sha }}
export PACKAGE_ID=${GRAFANA_PLUGIN_ID}-${SHA}
Expand Down Expand Up @@ -196,7 +196,7 @@ jobs:
deploy-to-dev:
# This triggers Argo workflow that will perform deployment to wave. Pushes to main will trigger deployment automatically
name: Deploy to dev
needs: [ package ]
needs: [package]
runs-on: ubuntu-latest
environment: ${{ github.event_name == 'push' && 'dev-no-approval' || 'dev' }}
steps:
Expand All @@ -205,10 +205,10 @@ jobs:
- name: Deploy to dev
uses: grafana/shared-workflows/actions/trigger-argo-workflow@trigger-argo-workflow-v1.0.0
with:
instance: "ops"
namespace: "phlare-cd"
workflow_template: "deploy-plugin-dev"
instance: 'ops'
namespace: 'phlare-cd'
workflow_template: 'deploy-plugin-dev'
parameters: |
plugintag=${{ needs.package.outputs.sha }}
extra_args: "--name deploy-plugin-dev-${{ needs.package.outputs.sha }}"
log_level: "debug"
extra_args: '--name deploy-plugin-dev-${{ needs.package.outputs.sha }}'
log_level: 'debug'
13 changes: 7 additions & 6 deletions docs/sources/access/profile-settings.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,16 @@ The **Profiles settings** page lets you modify flame graph, export, and function

![The Profiles Settings page](/media/docs/explore-profiles/explore-profiles-settings.png)

| Features | Options | Explanation |
| --------------------------- | -------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| **Collapsed flame graph** | Default: Off | When this feature is active, you can collapse flame graphs to minimize their screen space. |
| **Maximum number of nodes** | Default: 16384 | This number controls the maximum number of nodes, which controls the depth of the flame graph. The higher the number, the more nodes are used in the flame graph. The flame graphs appear longer. |
| Features | Options | Explanation |
| --------------------------- | -------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| **Collapsed flame graph** | Default: Off | When this feature is active, you can collapse flame graphs to minimize their screen space. |
| **Maximum number of nodes** | Default: 16384 | This number controls the maximum number of nodes, which controls the depth of the flame graph. The higher the number, the more nodes are used in the flame graph. The flame graphs appear longer. |

<!-- Commenting out flamegraph.com
| **Enable flamegraph.com** | Default: On | Adds a `flamegraph.com` export option to the **Export flame graph** menu. Flame graphs uploaded to `flamegraph.com` have a publicly accessible URL. Deactivate this option if data privacy is a concern. |
-->
| **Enable function details** | Default: On | Enables mapping of resource usage to lines of source code. If the [GitHub integration](https://grafana.com/docs/grafana-cloud/monitor-applications/profiles/pyroscope-github-integration/) is configured, then the source code is downloaded from GitHub. |

| **Enable function details** | Default: On | Enables mapping of resource usage to lines of source code. If the [GitHub integration](https://grafana.com/docs/grafana-cloud/monitor-applications/profiles/pyroscope-github-integration/) is configured, then the source code is downloaded from GitHub. |

## Modify settings

Expand All @@ -50,4 +51,4 @@ To export a flame graph:
1. Select the **Export** icon at the end of the toolbar.
![Available export options for the flame graph](/media/docs/grafana-cloud/profiles/profiles-export-flamegraph.png)
1. Choose an export option.
1. Save the file to your system. -->
1. Save the file to your system. -->
2 changes: 1 addition & 1 deletion docs/sources/concepts/flame-graphs.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ keywords:
[//]: # 'Shared content for intro to flame graphs.'
[//]: # 'This content is located in /pyroscope/docs/sources/shared/intro/flame-graphs.md'

{{< docs/shared source="pyroscope" lookup="intro/flame-graphs.md" version="<PYROSCOPE_VERSION>" >}}
{{< docs/shared source="pyroscope" lookup="intro/flame-graphs.md" version="<PYROSCOPE_VERSION>" >}}
1 change: 0 additions & 1 deletion docs/sources/concepts/profile-types.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,3 @@ For information on auto-instrumentation and supported language SDKs, refer to [C

[//]: # 'Shared content for profile type explanations.'
[//]: # 'This content is located in /pyroscope/docs/sources/shared/intro/profile-types-descriptions.md'

4 changes: 2 additions & 2 deletions docs/sources/investigate/flame-graph-ai.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ You can use Flame graph AI in Grafana **Explore** > **Profiles** and the Explore

### Before you begin

Flame graph AI is available only when using Explore Profiles.
Flame graph AI is available only when using Explore Profiles.

To use Flame graph AI, you must have:

- Configured a [Grafana Pyroscope data source](https://grafana.com/docs/grafana-cloud/connect-externally-hosted/data-sources/pyroscope/) that has profiling data
Expand Down
Loading

0 comments on commit 5b6e9bd

Please sign in to comment.