Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Track Ad Hoc view #377

Merged
merged 1 commit into from
Feb 4, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions src/pages/AdHocView/ui/tabs/AdHocSingle.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { SelectableValue } from '@grafana/data';
import { reportInteraction } from '@shared/domain/reportInteraction';
import React, { memo } from 'react';

import { useUploadFile } from '../../domain/useUploadFile';
Expand All @@ -9,10 +11,25 @@ import { AdHocSpinner } from '../AdHocSpinner';
function AdHocSingleComponent() {
const { processFile, profileTypes, selectProfileType, profile, removeFile, isLoading } = useUploadFile();

const onChangeProfileType = (options: SelectableValue<string>) => {
reportInteraction('g_pyroscope_app_ad_hoc_profile_metric_selected');
selectProfileType(options);
};

const onFileDropped = (file: File) => {
reportInteraction('g_pyroscope_app_ad_hoc_file_dropped', { fileType: file.type });
processFile(file);
};

const onFileRemoved = () => {
reportInteraction('g_pyroscope_app_ad_hoc_file_removed');
removeFile();
};

return (
<div>
<AdHocProfileTypeSelector profileTypes={profileTypes} onChange={selectProfileType} />
<AdHocFileDropZone onFileDropped={processFile} onFileRemove={removeFile} />
<AdHocProfileTypeSelector profileTypes={profileTypes} onChange={onChangeProfileType} />
<AdHocFileDropZone onFileDropped={onFileDropped} onFileRemove={onFileRemoved} />
{isLoading && !profile ? <AdHocSpinner /> : null}
{profile && <AdHocFlameGraph profile={profile} />}
</div>
Expand Down
6 changes: 6 additions & 0 deletions src/shared/domain/reportInteraction.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,12 @@ import { GIT_COMMIT } from '../../version';

// hey future dev: don't forget to add any new value to our features tracking dashboard!
export type Interactions = {
g_pyroscope_app_ad_hoc_file_dropped: {
fileType: string;
};
g_pyroscope_app_ad_hoc_file_removed: {};
g_pyroscope_app_ad_hoc_profile_metric_selected: {};
g_pyroscope_app_ad_hoc_profile: {};
g_pyroscope_app_compare_link_clicked: {};
g_pyroscope_app_diff_auto_select_clicked: {};
g_pyroscope_app_diff_choose_preset_clicked: {};
Expand Down
Loading