Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move trace view to a drawer #318

Merged
merged 3 commits into from
Feb 6, 2025
Merged

Conversation

adrapereira
Copy link
Collaborator

No description provided.

@adrapereira adrapereira self-assigned this Feb 4, 2025
@@ -227,6 +227,7 @@ export class REDPanel extends SceneObjectBase<RateMetricsPanelState> {
time: xSel?.from || 0,
xMin: xSel?.from || 0,
xMax: xSel?.to || 0,
timeEnd: xSel?.to || 0,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes another crash on the heatmap panel, something changed in Grafana so we need this now.

@adrapereira adrapereira requested review from joey-grafana and a team and removed request for joey-grafana February 5, 2025 13:18
Copy link
Collaborator

@joey-grafana joey-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few observations but this looks much better 👍

@adrapereira adrapereira merged commit 02ea808 into main Feb 6, 2025
4 checks passed
@adrapereira adrapereira deleted the andre/use-drawer-to-show-trace branch February 6, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants