Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to provide extra attributes to Measurements payload #254

Closed
3 of 4 tasks
codecapitano opened this issue Aug 23, 2023 · 3 comments · Fixed by #256
Closed
3 of 4 tasks

Make it possible to provide extra attributes to Measurements payload #254

codecapitano opened this issue Aug 23, 2023 · 3 comments · Fixed by #256
Assignees
Labels
feature Request a new feature

Comments

@codecapitano
Copy link
Collaborator

codecapitano commented Aug 23, 2023

Description

The measurement API is missing the option to add attributes/context data like the error, logorevent` APIs are doing.
User often need a possibility to transport extra information within the respective Meta.

Proposed solution

Add an option to pushMeasurement API to extra data.

Context

Community Slack

Tasks

Preview Give feedback
@codecapitano codecapitano added the feature Request a new feature label Aug 23, 2023
@codecapitano codecapitano changed the title Measurements API - Make it possible to provide extra attributes to the Measurements Meta Make it possible to provide extra attributes to the Measurements Meta Aug 23, 2023
@codecapitano codecapitano self-assigned this Aug 25, 2023
@codecapitano codecapitano changed the title Make it possible to provide extra attributes to the Measurements Meta Make it possible to provide extra attributes to Measurements payload Aug 25, 2023
@codecapitano
Copy link
Collaborator Author

@Memfisrain
Copy link

@codecapitano Hey, that is an extremely useful feature. Do you have any ETA?

Thanks for your work

@codecapitano
Copy link
Collaborator Author

codecapitano commented Aug 29, 2023

Hey @Memfisrain All related PR's are currently in review.
After the respective changes to the Grafana Agent are merged and released, we will merge and release the changes to the measurements API. Therefore I can't give you a hard estimate unfortunately but it shouldn't take long.

Cheers,
Marco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Request a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants