Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

254 make it possible to provide extra attributes to the measurements meta #256

Conversation

codecapitano
Copy link
Collaborator

@codecapitano codecapitano commented Aug 25, 2023

Why

The measurement API lags support of adding contextual attributes.

Note:
This requires changes or udates to the following components as well:

  • Grafana Agent
  • Faro Receiver
  • Docs (Website)

❗️Important❗️
Do not merge/release this PR until the Agent and Receivers changes have been merged and released.

What

Introduce an optional context object to pass with the PushMeasurementOptions object. Similar to the Logs and Errors APIs.

Links

Checklist

  • Tests added
  • Changelog updated
  • Documentation updated

@codecapitano codecapitano added the feature Request a new feature label Aug 25, 2023
@codecapitano codecapitano force-pushed the 254-make-it-possible-to-provide-extra-attributes-to-the-measurements-meta branch from e7b7ca8 to cd6c94b Compare August 25, 2023 15:56
@codecapitano codecapitano force-pushed the 254-make-it-possible-to-provide-extra-attributes-to-the-measurements-meta branch from e0b73f2 to 63c48c7 Compare August 28, 2023 15:35
@codecapitano codecapitano marked this pull request as ready for review September 11, 2023 14:32
@codecapitano codecapitano merged commit 9b23020 into main Sep 12, 2023
@codecapitano codecapitano deleted the 254-make-it-possible-to-provide-extra-attributes-to-the-measurements-meta branch September 12, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Request a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it possible to provide extra attributes to Measurements payload
2 participants