-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add contextual attributes to faro measurement #4975
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the MeasurementContext
. I had one question about adding Type
but I'm not sure if it's necessary in this PR.
@codecapitano looks like there are some additional test cases we should update:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test cases + changelog formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
58f2b8d
to
2a714f0
Compare
PR Description
In the Faro Web-SDK we added an option to provide additional contextual attributes to the measurements payload.
To enable this we need to update the agent as well.
Which issue(s) this PR fixes
Notes to the Reviewer
Just for reference here are the PRs which make the needed changes to the Faro Receiver and the Faro Web-SDK.
PR Checklist