Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Fix logging when setting GF_LOG=1 #154

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Fix logging when setting GF_LOG=1 #154

merged 3 commits into from
Aug 29, 2023

Conversation

borchero
Copy link
Contributor

Motivation

Currently, setting GF_LOG=1 results in the following error:

panic: interface conversion: io.Reader is *bytes.Reader, not *bytes.Buffer

@CLAassistant
Copy link

CLAassistant commented Jun 21, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

yuri-tceretian
yuri-tceretian approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@yuri-tceretian yuri-tceretian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuri-tceretian yuri-tceretian merged commit c093bc7 into grafana:master Aug 29, 2023
@borchero borchero deleted the fix-logging branch August 29, 2023 15:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yuri-tceretian yuri-tceretian yuri-tceretian approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@borchero @CLAassistant @yuri-tceretian