Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more metrics to the services #161

Merged
merged 17 commits into from
Aug 8, 2024
Merged

Add more metrics to the services #161

merged 17 commits into from
Aug 8, 2024

Conversation

andriikushch
Copy link
Contributor

@andriikushch andriikushch commented Aug 7, 2024 •
edited
Loading

This PR:

  • Adds more metrics to the services
  • Adds new services
  • Adds dimensions to the new services

@andriikushch andriikushch changed the title Andrii/add new metric Add more metrics to the services Aug 7, 2024
@andriikushch andriikushch marked this pull request as ready for review August 7, 2024 15:17
@andriikushch andriikushch requested a review from a team as a code owner August 7, 2024 15:17
kgeckhart
kgeckhart approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@kgeckhart kgeckhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

iwysiu
iwysiu approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@iwysiu iwysiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with one change!

pkg/cloudWatchConsts/metrics.go
@@ -3083,4 +3204,6 @@ var NamespaceDimensionKeysMap = map[string][]string{
"AWS/Cassandra": {"Keyspace", "Operation", "TableName"},
"AWS/AmplifyHosting": {"App"},
"CloudWatchSynthetics": {"CanaryName", "StepName"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if it's empty we should add AWS/ECR here (I think it errors if it doesn't exist)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @iwysiu!

Added here 692a75f.

@andriikushch andriikushch merged commit 48b8ce9 into main Aug 8, 2024
3 checks passed
@andriikushch andriikushch deleted the andrii/add-new-metric branch August 8, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgeckhart kgeckhart kgeckhart approved these changes

@iwysiu iwysiu iwysiu approved these changes

@kevinwcyu kevinwcyu Awaiting requested review from kevinwcyu kevinwcyu is a code owner automatically assigned from grafana/aws-datasources

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andriikushch @kgeckhart @iwysiu