Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostgreSQL as a data source #556

Closed
mohan-nagandlla opened this issue Oct 9, 2021 · 6 comments
Closed

PostgreSQL as a data source #556

mohan-nagandlla opened this issue Oct 9, 2021 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@mohan-nagandlla
Copy link

Hi team in standalone grafana we have a direct option to add grafana as a data source . In operator we have a CRD grafanadatasource I just want to add postgres add as a data source by using that CRD . Isn't possible to do like that

@mohan-nagandlla mohan-nagandlla added enhancement New feature or request needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 9, 2021
@david-martin
Copy link
Contributor

Hi @mohan-nagandlla

Do you mean using postgres for persistent storage and HA capabilities with grafana? (https://github.com/grafana-operator/grafana-operator/tree/master/deploy/examples/ha may be of use then)

Or do you mean pulling in metrics from postgres? (in which case you may be able to figure it out from the example data sources in https://github.com/grafana-operator/grafana-operator/tree/master/deploy/examples/datasources, in conjunction with the Grafana docs https://grafana.com/docs/grafana/latest/datasources/postgres/). However I'm not familiar with postgres as a data source or if anything is missing in the GrafanaDatasource CRD to allow using it.

@david-martin david-martin added triage/needs-information Indicates an issue needs more information in order to work on it. and removed needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 10, 2021
@mohan-nagandlla
Copy link
Author

Yes I just want you collect the data from postgres in the metrics formate but I don't found any exam. Yaml file in that link to add postgres as a data source

@david-martin
Copy link
Contributor

Thanks @mohan-nagandlla
On further inspection, it looks like what's needed is an update to the CRD to add a 'postgres' type and the corresponding field mappings,
akin to what was done for Azure #293 and Stackdriver #225

Marking this as accepted, and as a good-first-issue.
I don't see any issue with this being added.

@david-martin david-martin added good first issue Good for newcomers triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed triage/needs-information Indicates an issue needs more information in order to work on it. labels Oct 10, 2021
@Voigtus
Copy link
Contributor

Voigtus commented Oct 18, 2021

Wanted to grab that selfishly @david-martin
Just looked through the fields, and I can not find a single one, that is missing. Or am I missing something?

Maybe just an example is needed here

Voigtus added a commit to Voigtus/grafana-operator that referenced this issue Oct 30, 2021
Voigtus added a commit to Voigtus/grafana-operator that referenced this issue Oct 30, 2021
NissesSenap pushed a commit that referenced this issue Nov 9, 2021
* #556: adds example GrafanaDatasource for postgres

Co-authored-by: Edvin N <edvin.norling@xenit.se>
Co-authored-by: Hubert Stefanski <35736504+HubertStefanski@users.noreply.github.com>
@yardenshoham
Copy link
Contributor

Seeing as the code and CRDs are already in place, only the example was missing. Therefore #588 fixes this issue.

@NissesSenap
Copy link
Collaborator

Thanks for pointing that out @yardenshoham , I'm closing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

5 participants