remove permissions for openshift only resources in helm chart #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
NissesSenap
requested changes
Dec 19, 2023
Signed-off-by: Edvin Norling <edvin.norling@kognic.com>
NissesSenap
force-pushed
the
issue-1331
branch
from
6109bec
to
65d0a48
Compare
NissesSenap
approved these changes
Jan 13, 2024
|
LGTM, congratulations on your first helm PR @pb82 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1331
This removes all OpenShift related permissions (routes) from the Helm chart. I've verified that the Helm chart can still be deployed on OpenShift.