-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update operator version in deployment.yaml #1367
Conversation
Update operator version in deployment.yaml to get the correct version on install via kustomize
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, thanks @Links2004 !
Hey @Links2004
So if you download the kustomize artifact it should contain the correct version https://github.com/grafana/grafana-operator/pkgs/container/kustomize%2Fgrafana-operator/156599061?tag=v5.6.0 I don't see an issue with this PR, but it's also not a prat of our normal prepartions for a new release, since it already automated, so I see that this will happen again. FYI @HubertStefanski |
my current gitops process uses kustomize + argocd. basiclly it comes down to render everything with kustomize and commit it to git for argocd to pick it up. e.g. apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- github.com/grafana/grafana-operator/deploy/kustomize/overlays/cluster_scoped/?ref=v5.6.0
namespace: monitoring having flux as only options sounds not optimal to me, lets hope that kustomize or argocd gets support soon. Maybe it's worth checking out a release as tar.gz too (add to the release as Assets) based on https://kubectl.docs.kubernetes.io/references/kustomize/kustomization/resource/ URL specifications should follow the hashicorp URL format and hashicorp URL / go-getter has a archive option. but this need to be tested, had only a quick read of the docs. in case someone needs the patch that I had as workaround in the future: patches:
- target:
kind: Deployment
name: grafana-operator-controller-manager
patch: |-
- op: replace
path: "/spec/template/spec/containers/0/image"
value: ghcr.io/grafana/grafana-operator:v5.6.0 upsteam argo proposals: and may the docu needs an update since this part here will run in the same problems with the version that I had. grafana-operator/docs/docs/installation/kustomize.md Lines 24 to 52 in d3508c0
|
Trust me @Links2004 I want nothing else then have ArgoCD actually support OCI in a good way, and sadly I'm stuck with ArgoCD as well, so right now I use helm for my deployment. I'm open for other suggestions on how to provide Kustomize, as long as I don't manually have to update it in yaml manually. |
Update operator version in deployment.yaml to get the correct version on install via kustomize.