Trying to pass OLM CI #1387
Merged
Trying to pass OLM CI #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edvin Norling <edvin.norling@kognic.com>
Signed-off-by: Edvin Norling <edvin.norling@kognic.com>
HVBE
reviewed
Jan 22, 2024
config/manifests/bases/grafana-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
19 tasks
NissesSenap
commented
Jan 22, 2024
bundle/metadata/properties.yaml
Outdated
| @@ -0,0 +1,4 @@ | |||
| properties: | |||
There was a problem hiding this comment.
It seems like olm.maxOpenShiftVersion is not the same as com.redhat.openshift.versions: "v4.6-v4.8"
I guess i missunderstood the docs https://docs.openshift.com/container-platform/4.8/operators/operator_sdk/osdk-working-bundle-images.html
I will play with this later
|
Thanks to open-telemetry/opentelemetry-operator#2562 I think I have managed to find a "good" way of getting these annotations in order. |
|
Looks like the new CI stuff passed in redhat-openshift-ecosystem/community-operators-prod#3915 at least. So I think this should be ready to go, from a OLM yaml point of view |
HVBE
approved these changes
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.