[helm] Support for Servicemonitor #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
|
@nlamirault Thanks for the PR! I'll let one of the maintainers that are more familiar with helm handle this one |
NissesSenap
reviewed
Feb 7, 2024
There was a problem hiding this comment.
First of all thanks for the PR.
We have metricsService https://github.com/grafana/grafana-operator/blob/master/deploy/helm/grafana-operator/values.yaml#L53-L57 since earlier. In retrospect I probably picked a rather bad name for that value. So it could potentially be good to use that.
At the same time we have metrics name hard coded
so it's actually not needed. I guess easiest is to leave it as is.So lets skip that, but take a look at the comment and add namespace.
| {{- end }} | ||
| {{- with .Values.serviceMonitor.additionalLabels }} | ||
| {{- toYaml . | nindent 4 }} | ||
| {{- end }} |
There was a problem hiding this comment.
Due to earlier PR we set namespace in all templates, so please add that to this one as well.
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
NissesSenap
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.