chore: add cross namespace e2e test #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddycharly
commented
Feb 21, 2024
| name: example-grafanadatasource | ||
| namespace: (join('-', ['cross', $namespace])) | ||
| status: | ||
| (lastMessage != null): true |
There was a problem hiding this comment.
This is the only way i found to verify the data source was adopted.
eddycharly
force-pushed
the
chainsaw-2
branch
from
cf22fdb
to
5a0b655
Compare
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
eddycharly
force-pushed
the
chainsaw-2
branch
from
5a0b655
to
5f02705
Compare
eddycharly
commented
Feb 21, 2024
| metadata: | ||
| name: crossnamespace | ||
| spec: | ||
| concurrent: false |
There was a problem hiding this comment.
Note that this tests doesn't run concurrently to make sure the data source was adopted by the expected grafana.
NissesSenap
approved these changes
Feb 24, 2024
|
LGTM, thanks @eddycharly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cross namespace e2e test.