-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add contactpoint resource #1474
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! Works well and the overall code quality looks good
I have some concerns around UID handling. The current approach does not allow for renaming of resources, as the UID is retrieved by matching the name.
IMHO a better approach would be to use the Kubernetes UID (part of the object metadata). This way we don't have to do any name matching in the operator and have a consistent UID. We do something similar in the folder resource.
Co-authored-by: Dominik Süß <dominik@suess.wtf>
I agree with you, will change it to use the K8s UID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Please fix the last whitespace issue and we're good to merge from my side.
@pb82 @NissesSenap - can you take a quick look at this as well? I've tested this but can't hurt to have someone else take a glance at this as well
Thanks @theSuess , I just removed the whitespace so hopefully passes that last test now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, looking forward to hearing some reports of how well this works for our users, awesome work! thank you @duncan485
…yaml 5.9.0 introduced grafanacontactpoint (grafana#1474), and the needed rbac permissions were added to config/rbac/role.yaml, but not to the kustomize deployment
Any feedback is highly appreciated! Used #1420 as a refrence to create this.
closes #1455