-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add helm upgrade instructions #1481
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add solves #1325
To avoid issues due to outdated or missing definitions, run the following command before updating an existing installation: | ||
|
||
```shell | ||
kubectl apply --server-side --force-conflicts -f https://github.com/grafana/grafana-operator/releases/download/v5.8.1/crds.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we write something about, adjust the release version to the helm chart version. Or add some variable that we use for both the commands?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variables would be nice, but I'm not sure how frequently people check out the doc on the website (where variables work) vs viewing the README on GitHub (where they don't) 🤔. What's your take on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now, we are using variables everywhere in the document. I see your point of that many people just check directly in the helm chart. But at the same time, it would be nice if we have some kind of automation around this for the documentation page as well.
So if we should change this, I think we should do it in a separate PR.
Adds a section for upgrading helm with regards to CRDs