-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: apply duration validation to all resync periods #1505
Conversation
@pb82 you need to update your kubebuilder version locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pb82 I've regenerated manifests with kubebuilder v0.14.0 and tested the validation, everything seems to be fine, I think we should be good to merge the PR.
thanks @weisdd ! |
@weisdd kustomize crds are not yet updated, let me fix this |
@pb82 LGTM |
…o grafanacontactpoints (#1506) * fix(makefile): generate CRDs with descriptions to be later used for api-docs * fix(kustomization): add grafanacontactpoints to the kustomization used for api-docs * fix(crds, api-docs): generate CRDs and api-docs
fixes #1483
adds validation to all
ResyncPeriod
fields. It can only be a valid Go duration string and it defauts to5m
.