feat/fix(rbac): use generated RBAC in kustomize and helm, grant access to leases #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weisdd
requested review from
NissesSenap,
ishanjainn,
theSuess and
pb82
as code owners
weisdd
changed the title
NissesSenap
approved these changes
May 20, 2024
|
Yeah, due to the way how the diff is rendered on GitHub, the change looks more complex than it actually is. Thanks for the review! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once in a while, we see inconsistencies in RBAC definitions across different deployment options.
This PR aims to fix inconsistencies in kustomize overlays and helm by making them use generated RBAC role definition (
config/rbac/role.yaml).While working on this, I've also noticed that
config/rbac/role.yamldoes not contain permissions for leases (used for elections), this is also fixed through a kubebuilder annotation.Another improvement is around PR validation workflow: added a step to validate kustomize overlays by trying to build them.
Fixes: #1541