Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CRDs): publish full CRDs #1579

Merged
merged 3 commits into from
Jun 17, 2024
Merged

chore(CRDs): publish full CRDs #1579

merged 3 commits into from
Jun 17, 2024

Conversation

weisdd
Copy link
Collaborator

@weisdd weisdd commented Jun 13, 2024

Previously, we would publish CRDs without description to avoid issues when doing client-side applies (e.g. kubectl doesn't like long descriptions).
During the last meeting, we discussed that, with server-side applies, we don't expect to see any issues. Thus the PR.

Changes:

  • remove separate set of CRDs that was used for generating API documentation;
  • point crdoc at config/crd/bases;
  • adjust controller-gen commands to generate full CRDs;
  • use server-side apply in deploy and deploy-chainsaw.

Fixes: #1567

Copy link
Member

@theSuess theSuess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this!

@theSuess theSuess added this pull request to the merge queue Jun 17, 2024
Merged via the queue into master with commit 515c190 Jun 17, 2024
14 checks passed
@theSuess theSuess deleted the chore/publish-full-crds branch June 17, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] CRD description fields in all CRDs lost between 5.8.1 and 5.9.0
2 participants