fix: use frontend settings endpoint for version detection #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the version detection logic to use the frontend settings endpoint as it is more reliable, especially on cloud provider offerings. Fixes #1569
theSuess
requested review from
NissesSenap,
weisdd,
ishanjainn,
HVBE and
pb82
as code owners
|
I haven't tried to run the operator against managed Grafana in Azure, but I see that the endpoint is accessible using a service account and the required information is present: |
We need to fix this issue, so we need ppc64le v5.9.2 Failed to pull image "ghcr.io/grafana/grafana-operator@sha256:e7923d1a71b90a8ad66d114aec4b2b4e4929f15ba91872f64c5e271629612284": rpc error: code = Unknown desc = choosing image instance: no image found in image index for architecture ppc64le, variant "", OS linux
Update release.yaml to add linux/ppc64le
weisdd
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the version detection logic to use the frontend settings endpoint as it is more reliable, especially on cloud provider offerings.
Fixes #1569
I don't currently have access to Azure/Amazon managed Grafana so we'd need someone else to test this. It works for Grafana cloud & operator managed instances