add proposal for GrafanaLibraryPanel CRD #1611
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diurnalist
requested review from
NissesSenap,
weisdd,
ishanjainn,
theSuess,
HVBE and
pb82
as code owners
NissesSenap
reviewed
Jul 16, 2024
There was a problem hiding this comment.
Really nice feature to get, thanks for the initial design.
Personally I think it would be interesting to discuss how the dashboard would reference lib panels. I think it would be reasonable to do it in a similar way as we do here: #1604
Just because we talk about the design, doesn't mean that we have to have this feature to be a part of the initial implementation, but it might have an impact on how we make the implementation.
How do you feel about it?
|
This PR hasn't been updated for a while, marking as stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds a proposal for a GrafanaLibraryPanel CRD, which would enable the operator to manage Library Panels similar to other assets. the Library Panel behaves similar as a Dashboard; it has a JSON model and can optionally be associated to a Folder.
full disclosure: we actually have a patch that we are using in production that implements the proposal documented here. We don't have chainsaw tests for it though; I think that would be one possible next step. still, open to discussion about the approach. we opted to implement this with high parity with how Dashboards worked because we reasoned folks might want to manage the JSON models for both in similar ways, be that as config maps, or nested on the CR itself, or external URL.