feat: basic auth support for dashboards from url #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pb82
requested review from
NissesSenap,
weisdd,
ishanjainn,
theSuess and
HVBE
as code owners
pb82
force-pushed
the
url-dashboard-auth
branch
from
4ac444c
to
44d6977
Compare
|
|
pb82
force-pushed
the
url-dashboard-auth
branch
from
44d6977
to
d10e4fb
Compare
pb82
force-pushed
the
url-dashboard-auth
branch
2 times, most recently
from
80fab87
to
b5b92d4
Compare
pb82
force-pushed
the
url-dashboard-auth
branch
2 times, most recently
from
c923596
to
f4d60a6
Compare
This correctly uses envtest to support kubernetes api interactions
theSuess
force-pushed
the
url-dashboard-auth
branch
from
4b4d590
to
53aef3b
Compare
theSuess
changed the title
theSuess
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for basic auth when fetching dashboards from URL. The field is ignored for any other dashboard source.