Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): add support for mute timing #1817

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chenlujjj
Copy link
Contributor

To resolve: #1723

@chenlujjj chenlujjj marked this pull request as draft January 11, 2025 13:31
@chenlujjj chenlujjj force-pushed the feat/mute-timing branch 6 times, most recently from bddf524 to 2420950 Compare January 11, 2025 14:52
@chenlujjj chenlujjj marked this pull request as ready for review January 11, 2025 15:07
@chenlujjj
Copy link
Contributor Author

tested in local:

---
apiVersion: grafana.integreatly.org/v1beta1
kind: GrafanaMuteTiming
metadata:
  name: mutetiming-sample
spec:
  instanceSelector:
    matchLabels:
      dashboards: "grafana"
  name: mutetiming-sample
  editable: false
  time_intervals:
    - times:
        - start_time: "00:00"
          end_time: "06:00"
      weekdays: ["saturday", "sunday"]
      days_of_month: ["1", "10"]
      location: "Asia/Shanghai"

result:
image

@theSuess
Copy link
Member

Thanks for the PR! I'll take a look at this soon. It's too big of a change for the next release, but we'll get it out soon now that the holiday season is over

@theSuess theSuess added this to the v5.17.0 milestone Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Provision mute time intervals trough the operator
2 participants