Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for timezone in jsonData for MySQL data source #695

Merged
merged 3 commits into from
Mar 8, 2022

Conversation

daha
Copy link
Contributor

@daha daha commented Mar 4, 2022

Description

Add support for the new field timezone, in jsonData, used by the MySQL data source:
https://grafana.com/docs/grafana/latest/datasources/mysql/

Relevant issues/tickets

None

Type of change

Not sure if this is breaking or not. It whitelists one field in jsonData in the datasource CRD.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • This change requires a documentation update
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a test case that will be used to verify my changes
  • Verified independently on a cluster by reviewer

Verification steps

  • Create datasource with the field timestamp in jsonData and verify that the timezone is present in the datasource.

Copy link
Collaborator

@HVBE HVBE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HVBE HVBE merged commit 8d38e61 into grafana:master Mar 8, 2022
@daha daha deleted the mysql-timezone-config branch March 31, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants