Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remaining [plugin] fields to Grafanas.spec.config.plugins #802

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

meln5674
Copy link
Contributor

@meln5674 meln5674 commented Jul 25, 2022

Description

Added the following fields to Grafana.spec.config.plugins

  • allow_loading_unsigned_plugins
  • plugin_admin_enabled
  • plugin_catalog_url
  • plugin_catalog_hidden_plugins
  • (plugin_admin_external_manage_enabled deliberately omitted as it only applied to Grafana Cloud)

Added CRD field docstrings copied from official grafana documentation.

Added example manifest demonstrating usage

Relevant issues/tickets

Fixes #801

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • This change requires a documentation update
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a test case that will be used to verify my changes
  • Verified independently on a cluster by reviewer

Verification steps

kubectl apply -f deploy/examples/GrafanaDevEnv.yaml
kubectl get -o yaml configmap grafana-config

@meln5674 meln5674 force-pushed the feature/grafana-operator-801 branch 5 times, most recently from 08b8478 to 22ca154 Compare July 26, 2022 02:28
@meln5674 meln5674 force-pushed the feature/grafana-operator-801 branch from 22ca154 to 62ef963 Compare July 26, 2022 16:01
Copy link
Collaborator

@NissesSenap NissesSenap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great that you added good comments as well.

@NissesSenap NissesSenap merged commit 0146452 into grafana:master Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support [plugin] grafana.ini fields
2 participants