extend kubeRbacProxy helm configuration #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakito
force-pushed
the
rbac-proxy-config
branch
2 times, most recently
from
133ff83
to
f138740
Compare
bakito
force-pushed
the
rbac-proxy-config
branch
from
f138740
to
2fe6446
Compare
bakito
changed the title
|
Hey @bakito , thanks for the PR! I'm not very familiar with Helm, so I defer to @NissesSenap or @weisdd |
|
Thanks allot @bakito I did a few minor changes, one indentation and update of of some comment in the values file. |
NissesSenap
approved these changes
Mar 18, 2023
you're welcome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The helm config of kube rbac proxy had some unmapped values, which are now correctly mapped.
Also additional properties such as securityContext, liveness- / readynessProbe and reyources can now be defined for the kube rbac proxy container.