Chore: Fix DeepCopyInto for DataQuery #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantxu
reviewed
Sep 10, 2024
| @@ -246,7 +246,7 @@ func (g *DataQuery) DeepCopyInto(out *DataQuery) { | |||
| out.additional = map[string]any{} | |||
| if len(g.additional) > 0 { | |||
| jj, err := json.Marshal(g.additional) | |||
| if err != nil { | |||
| if err == nil { | |||
toddtreece
requested review from
wbrowne,
marefr,
oshirohugo and
ryantxu
and removed request for
a team
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This generated name retry function was added in
0.30.0. it adds a call toDeepCopyObject, which creates a copy of the object before passing it to storage. The copied object is missing properties due a bug inDataQuery.DeepCopyInto, but the bug was not obvious until the upstream changes triggered the bug.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: