Chore: CI: Bump grafana-plugin-ci image to 1.9.5 #780
Conversation
| - apt update | ||
| - apt install -y gcc |
There was a problem hiding this comment.
go test -race requires CGO and a C compiler installed:
root@df30cca174ec:/src# mage -v testRace
Running target: TestRace
exec: go "test" "-race" "./..."
go: -race requires cgo; enable cgo by setting CGO_ENABLED=1
root@df30cca174ec:/src# CGO_ENABLED=1 mage -v testRace
Running target: TestRace
exec: go "test" "-race" "./..."
go: downloading github.com/mitchellh/reflectwalk v1.0.2
# runtime/cgo
cgo: C compiler "gcc" not found: exec: "gcc": executable file not found in $PATH
There was a problem hiding this comment.
Long term I say we should probably stop using those images and use the Go image + mage, and golangci-images, similar to what we do for example in the plugin runner:
https://github.com/grafana/grafana-plugin-runner/blob/main/.drone.yml
There was a problem hiding this comment.
Weird that it requires CGO. Was this in CI or for you locally?
Long term I say we should probably stop using those images and use the Go image + mage, and golangci-images
Yeah sounds like a good idea 👍
There was a problem hiding this comment.
Weird that it requires CGO. Was this in CI or for you locally?
Both locally and CI. Unfortunately it's a requirement: https://go.dev/doc/articles/race_detector#Requirements
I wasn't aware of this either before today 😅
There was a problem hiding this comment.
I see. Hopefully things evolve eventually golang/go#9918 (comment)
| @@ -44,22 +49,27 @@ trigger: | |||
|
|
|||
| steps: | |||
| - name: build | |||
| image: grafana/grafana-plugin-ci:1.8.1-alpine | |||
| image: grafana/grafana-plugin-ci:1.9.5 | |||
There was a problem hiding this comment.
Since 1.9.0, we stopped building alpine-based images. Only debian-based ones are available:
xnyo
requested review from
wbrowne,
marefr and
andresmgot
and removed request for
a team
What this PR does / why we need it:
Bumps the image used to run CI steps. Brings the following changes:
golangci-lintis usedPreviously, we used Alpine-based images. Since
1.9.0of the image, we stopped building them:https://hub.docker.com/r/grafana/grafana-plugin-ci/tags
So we are using Debian-based images now.
go test -racerequires CGO and a C compiler, for this reason we have to install gcc and enable CGO in the test step.Long term I say we should probably stop using those
grafana-plugin-ciimages and use the Go image + mage, and golangci-lint separately, similar to what we do for example in the plugin runner:https://github.com/grafana/grafana-plugin-runner/blob/main/.drone.yml
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: