Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offset function added #638

Merged
merged 2 commits into from
Nov 28, 2018
Merged

Offset function added #638

merged 2 commits into from
Nov 28, 2018

Conversation

drakosha
Copy link
Contributor

Will resolve #637.

Adding a shift function.

@drakosha drakosha mentioned this pull request Nov 7, 2018
Closed
@Laakso
Copy link

Laakso commented Nov 8, 2018

Yes finally. 😊

@alexanderzobnin
Copy link
Collaborator

@drakosha thanks for the PR! Could you rename function from shift to offset? My motivation is to keep names accordingly to other Graphite functions, like scale, sumSeries, timeShift, movingAverage and other. There's offset function in Graphite, but no shift. Also, shift may be confused with timeShift.
This will fix #387.

@drakosha drakosha changed the title Shift function added Offset function added Nov 28, 2018
@drakosha
Copy link
Contributor Author

@alexanderzobnin not a problem, done.

@alexanderzobnin alexanderzobnin merged commit e363368 into grafana:master Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add shift function to metrics
3 participants
@drakosha @Laakso @alexanderzobnin