Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't update permissions on role #13507

Closed
torkelo opened this issue Oct 3, 2018 · 1 comment · Fixed by #13509
Closed

Can't update permissions on role #13507

torkelo opened this issue Oct 3, 2018 · 1 comment · Fixed by #13509
Labels
area/permissions type/bug
Milestone
5.3

Comments

@torkelo
Copy link
Member

torkelo commented Oct 3, 2018

Recent redux migration caused some issues with updating role permissions (sends the same permissions many times).

problem line is here:
https://github.com/grafana/grafana/blob/master/public/app/features/folders/state/actions.ts#L113
@torkelo torkelo added this to the 5.3 milestone Oct 3, 2018
@jschill
Copy link
Contributor

jschill commented Oct 3, 2018

Same thing, but with dashboards:
https://github.com/grafana/grafana/blob/master/public/app/features/dashboard/state/actions.ts#L61

jschill added a commit that referenced this issue Oct 3, 2018
@jschill
Fix issue with updating role permissions #13507
97802f3
@jschill jschill mentioned this issue Oct 3, 2018
Merged
bergquist added a commit that referenced this issue Oct 3, 2018
@bergquist
Merge pull request #13509 from grafana/13507-permissions-on-role-fix
f35fd0c 
Fix issue with updating role permissions #13507
bergquist pushed a commit to bergquist/grafana that referenced this issue Oct 3, 2018
@jschill @bergquist
Fix issue with updating role permissions grafana#13507
272840e 
(cherry picked from commit 97802f3)
bergquist added a commit that referenced this issue Oct 3, 2018
@bergquist
changlog: adds note about closing #13551 and #13507
00b4c17
ryantxu added a commit to ryantxu/grafana that referenced this issue Oct 3, 2018
@ryantxu
Merge remote-tracking branch 'grafana/master' into panel-visibility-flag
608f1de 
* grafana/master: (85 commits)
  changelog: set date for 5.3.0-beta3 release
  build: fix for invalid pathing for release publisher
  changlog: adds note about closing grafana#13551 and grafana#13507
  test: updated react snapshot
  ux: minor tweak to link
  stackdriver: adds missing nginject attribute
  Fix issue with updating role permissions grafana#13507
  fixed toggle buttons
  build: automatically publish releases to grafana.com.
  updated after pr feedback
  Revert "Revert "Org users to react""
  Revert "Org users to react"
  added slow queries scenario to test data source, added new panel test dashboard with slow queries
  Fix "appropriate"-typo
  Update configuration doc to include socket@server
  wip: began work on support for testdata tables & annotations support
  changelog: adds note about closing grafana#13492
  better comment about state changes
  get or create alert notification should use transaction
  use notification state id instead of notifier id
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/permissions type/bug
Projects
None yet
Milestone
5.3
Development

Successfully merging a pull request may close this issue.

Fix issue with updating role permissions #13507 grafana/grafana
2 participants
@torkelo @jschill