Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support OAuth providers that are not RFC6749 compliant #14562

Closed
tdabasinskas opened this issue Dec 18, 2018 · 1 comment · Fixed by #14563
Closed

Support OAuth providers that are not RFC6749 compliant #14562

tdabasinskas opened this issue Dec 18, 2018 · 1 comment · Fixed by #14563
Labels
area/auth/oauth type/feature-request
Milestone
6.0-beta1

Comments

@tdabasinskas
Copy link
Contributor

What Grafana version are you using?

v5.4.2

What datasource are you using?

N/A

What OS are you running grafana on?

Docker

What did you do?

Configure auth.generic_oauth with a custom provider provider, which does not client_id/client_secret passed via Basic Auth HTTP header.

What was the expected result?

client_id and client_secret are passed as part of POST body payload, allowing to successfully authenticate using this OAuth provider.

What happened instead?

Authentication fails with login.OAuthLogin(NewTransportWithCode) error message in GUI and oauth2: cannot fetch token: 400 Bad Request\nResponse: {\"error\":\"invalid_client\"} error in logs.

If related to metric query / data viz:

N/A

Include raw network request & response: get by opening Chrome Dev Tools (F12, Ctrl+Shift+I on windows, Cmd+Opt+I on Mac), go the network tab.

N/A
@tdabasinskas tdabasinskas mentioned this issue Dec 18, 2018
Merged
@bergquist bergquist changed the title Generic OAuth client does not work with some providers Support OAuth providers that are not RFC6749 compliant Dec 19, 2018
bergquist added a commit that referenced this issue Dec 19, 2018
@bergquist
changelog: adds note about closing #14562
7637ea5
@marefr marefr added this to the 6.0 milestone Dec 19, 2018
ryantxu added a commit to ryantxu/grafana that referenced this issue Dec 19, 2018
@ryantxu
Merge remote-tracking branch 'grafana/master'
9c086be 
* grafana/master: (41 commits)
  Fixes undefined issue with angular panels and editorTabs
  changelog: adds note about closing grafana#14562
  Update field name
  Add documentation
  Rename the setting and add description
  export init notifier func
  Increase recent and starred limit in search and home dashboard, closes grafana#13950
  changelog: adds note about closing grafana#14486
  Panel help view fixes
  Add min/max height when resizing and replace debounce with throttle
  changelog: adds note about closing grafana#14546
  Adding tests for auth proxy CIDR support
  changelog: adds note about closing grafana#14109
  fix signed in user for orgId=0 result should return active org id
  Another take on resizing the panel, now using react-draggable
  Raise datasources number to 5000
  copy props to state to make it visible in the view
  refactor to not crash when no links
  updating snaps
  renaming component
  ...
ryantxu added a commit to ryantxu/grafana that referenced this issue Dec 19, 2018
@ryantxu
Merge remote-tracking branch 'grafana/master' into timepicker-tooltip
a15dc23 
* grafana/master: (2079 commits)
  Fixes undefined issue with angular panels and editorTabs
  changelog: adds note about closing grafana#14562
  Update field name
  Add documentation
  Rename the setting and add description
  export init notifier func
  Increase recent and starred limit in search and home dashboard, closes grafana#13950
  changelog: adds note about closing grafana#14486
  Panel help view fixes
  Add min/max height when resizing and replace debounce with throttle
  changelog: adds note about closing grafana#14546
  Adding tests for auth proxy CIDR support
  changelog: adds note about closing grafana#14109
  fix signed in user for orgId=0 result should return active org id
  Another take on resizing the panel, now using react-draggable
  Raise datasources number to 5000
  copy props to state to make it visible in the view
  refactor to not crash when no links
  updating snaps
  renaming component
  ...
@marefr marefr modified the milestones: 6.0, 6.0-beta1 Jan 29, 2019
@buroa
Copy link

buroa commented Feb 11, 2019 •
edited
Loading 

[auth.generic_oauth]
...
send_client_credentials_via_post = true
...

This would use POST instead of building the Authorization: Basic header.

@marefr marefr mentioned this issue Feb 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/auth/oauth type/feature-request
Projects
None yet
Milestone
6.0-beta1
Development

Successfully merging a pull request may close this issue.

Support OAuth providers that are not RFC6749 compliant
3 participants
@marefr @tdabasinskas @buroa