Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ease process to troubleshoot Graphite errors #265

Closed
dutchiechris opened this issue Apr 1, 2014 · 9 comments
Closed

Ease process to troubleshoot Graphite errors #265

dutchiechris opened this issue Apr 1, 2014 · 9 comments
Labels
prio/critical Highest priority. Must be actively worked on as someone's top priority right now.

Comments

@dutchiechris
Copy link

Currently a red bar is shown with "Oops! Graphite HTTP Error Request" when Graphite hits a problem. As far as I can tell, there is no way to see what the error was without additional troubleshooting such as using inspect like in this example:
image

Request is for Grafana to somehow allow access to the error info natively. Maybe if you click on the ! icon it would open a new window with just the render post so you could see the exact error straight away?

@syepes
Copy link
Contributor

syepes commented Apr 1, 2014

+1 That would be nice

@torkelo
Copy link
Member

torkelo commented Apr 1, 2014

Yes, this would be great. High prio :)

@torkelo
Copy link
Member

torkelo commented Apr 3, 2014

Started this today. Initial version (can always be improved) should be done tomorrow or this weekend.

image

@torkelo torkelo closed this as completed in 5cb4cfc Apr 5, 2014
@torkelo
Copy link
Member

torkelo commented Apr 5, 2014

image

image

The full graphite html error page is visible in the response tab (see screenshot in comment before this)

@syepes
Copy link
Contributor

syepes commented Apr 5, 2014

Great work, this is going to be really useful.

@frejsoya
Copy link

frejsoya commented Apr 8, 2014

Doesn't this require setting DEBUG=True in graphite? I guess it's an issue in graphite not reporting errors in json.

@torkelo
Copy link
Member

torkelo commented Apr 8, 2014

@frejsoya good point. I am not sure what the error page looks like when DEBUG=False.

@brutasse
Copy link
Contributor

brutasse commented Apr 9, 2014

It's HTML as well but with a different style & less information. So it'll keep working.

Graphite-api sometimes returns 400 responses in JSON, for instance when there is no target parameter. In this case displaying that in an iframe doesn't work.

Ultimately I'd like graphite-api to validate inputs and return proper error messages in 400 responses instead throwing server errors for arity issues.

I can probably write a patch to support JSON errors as well as HTML ones if you're willing to accept it :)

@torkelo
Copy link
Member

torkelo commented Apr 9, 2014

JSON errors would be great. Especially with some simple generic schema that is easy to render as html.

Dieterbe added a commit to Dieterbe/grafana that referenced this issue Jul 7, 2015
* share LRU cache amongst all executors. fix grafana#271
* make alerting parameters configurable. fix grafana#128
* document alerting and config options. fix grafana#265
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio/critical Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Development

No branches or pull requests

5 participants