Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs: Deprecate showContextToggle #66819

Closed
matyax opened this issue Apr 19, 2023 · 0 comments · Fixed by #77232
Closed

Logs: Deprecate showContextToggle #66819

matyax opened this issue Apr 19, 2023 · 0 comments · Fixed by #77232

Comments

@matyax
Copy link
Contributor

matyax commented Apr 19, 2023

In the initial implementation, there were conditions used to decide whether to show the context toggle or not for log rows. Now it seems that those conditions are no longer necessary, and we just display the option by default.

Most implementations are just returning true:

We should consider deprecating the option and defaulting to always display it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant