Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logs data source: deprecate showContextToggle #215

Merged
merged 5 commits into from
Feb 14, 2024
Merged

Logs data source: deprecate showContextToggle #215

merged 5 commits into from
Feb 14, 2024

Conversation

matyax
Copy link
Contributor

@matyax matyax commented Oct 27, 2023

Part of grafana/grafana#77232, where we're deprecating the showContextToggle function.

Which issue(s) this PR fixes:

Related to grafana/grafana#66819

@matyax matyax mentioned this pull request Oct 27, 2023
Merged
@ivanahuckova
Copy link
Member

I guess, we can just leave this open until 10.3 with deprecated showContext is released.

@matyax matyax force-pushed the matyax/deprecate-show-context-toggle branch from 45f407a to 8894488 Compare December 11, 2023 11:15
@matyax matyax requested review from a team as code owners February 9, 2024 12:05
@matyax matyax requested review from jackw, wbrowne, marefr and oshirohugo and removed request for a team February 9, 2024 12:05
@academo
Copy link
Member

academo commented Feb 12, 2024

@matyax can you remove this code without modifying the underlying grafana version of the example or waiting for the new release?

@matyax
Copy link
Contributor Author

matyax commented Feb 13, 2024

Hey @academo ! I'm not really sure what you mean. Is it about upgrading @grafana/data? Because I did it to get updated types from that package.

@academo
Copy link
Member

academo commented Feb 14, 2024

Hey @academo ! I'm not really sure what you mean. Is it about upgrading @grafana/data? Because I did it to get updated types from that package.

Yes indeed. If you need it upgraded then It is ok. We like to keep all the examples synced with the same versions so we can reliable know what's happening to them.

@matyax
Copy link
Contributor Author

matyax commented Feb 14, 2024

Yes, it's required, and I've been waiting for the 10.3 release for this. Thanks for checking!

@matyax matyax merged commit cf55e6b into main Feb 14, 2024
24 checks passed
@matyax matyax deleted the matyax/deprecate-show-context-toggle branch February 14, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanahuckova ivanahuckova ivanahuckova approved these changes

@svennergr svennergr Awaiting requested review from svennergr

@jackw jackw Awaiting requested review from jackw jackw is a code owner automatically assigned from grafana/plugins-platform-frontend

@wbrowne wbrowne Awaiting requested review from wbrowne wbrowne is a code owner automatically assigned from grafana/plugins-platform-backend

@marefr marefr Awaiting requested review from marefr marefr is a code owner automatically assigned from grafana/plugins-platform-backend

@oshirohugo oshirohugo Awaiting requested review from oshirohugo oshirohugo is a code owner automatically assigned from grafana/plugins-platform-backend

Assignees
No one assigned
Labels
None yet
Projects
Plugins Platform / Grafana Community
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matyax @ivanahuckova @academo