Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Add an option to attach graph image link in Pushover notification #8043

Closed
jpeg2600 opened this issue Apr 5, 2017 · 6 comments
Labels
area/alerting/notifications Issues when sending alert notifications type/feature-request
Milestone

Comments

@jpeg2600
Copy link

jpeg2600 commented Apr 5, 2017

As asked by @devkid in #8006, I open an issue to request a new feature.

Would it be possible to add an option to attach the link to the rendered graph uploaded to S3 in a Pushover notificaiton? The webhook outputs the info variable imageUrl, so I guess that the info is already somewhere accessible.

{ "title": "My alert", "ruleId": 1, "ruleName": "Load peaking!", "ruleUrl": "http://url.to.grafana/db/dashboard/my_dashboard?panelId=2", "state": "Alerting", "imageUrl": "http://s3.image.url", "message": "Load is peaking. Make sure the traffic is real and spin up more webfronts", "evalMatches": [ { "metric": "requests", "tags": {}, "value": 122 } ] }

I use Grafana to display the temperatures of a very sensitive environment . A quick peak on the graph when there's an alert would be useful on mobile and it loads quicker. The curve of a broken furnace and the one of a door left open is very different and tells at what speed we must rush to the site.

A simple link attached to the message would work fine. Thanks!

@alfredkrohmer
Copy link
Contributor

Just as a preliminary comment: I hope you don't rely on Pushover notifications in Grafana for critical situations. Currently, the Pushover plugin only tries to execute the API call once and doesn't retry if it fails (e.g. when the API server is down or some other reason).

@jpeg2600
Copy link
Author

jpeg2600 commented Apr 5, 2017

@devkid I have an homemade gateway that sends the alert as a SMS but I would like to only use pushover instead for the simplicity of it... Do you have any other suggestion?

@alfredkrohmer
Copy link
Contributor

alfredkrohmer commented Apr 5, 2017

Nope, my comment was just to underline that Pushover notifications in Grafana are not reliable in terms of repeat-until-delivered, which should be considered for critical situations. It's totally up to you how to handle your alerts and how you define "critical" :)

@jpeg2600
Copy link
Author

jpeg2600 commented Apr 5, 2017

I understand. Thanks for bringing up the concern. Both your notification plugin and pushover are probably more reliable than my homemade tool anyway!

I wish I could help out and add the functionnality myself, but I lack the time to learn how to use Github, the language and how everything works together.

Are you planning on adding the retry functionnality? I wonder if other notification plugins does that.

@alfredkrohmer
Copy link
Contributor

alfredkrohmer commented Apr 9, 2017

Looks like so:

screenshot_20170409-202153

You need to tick the "Include image" option on the notification settings and configure an external storage like so.

@jpeg2600
Copy link
Author

jpeg2600 commented Apr 9, 2017

Hey great work there @devkid ! I can't wait to try this out. Should I close the issue?

@torkelo torkelo closed this as completed Apr 10, 2017
@torkelo torkelo added this to the 4.3.0 milestone Apr 10, 2017
daniellee added a commit that referenced this issue May 10, 2017
ref #8277, ref #8250, ref #8262, ref #8165, ref #8093, ref #8056, ref #8043, ref #7970, ref #7914, ref #7864, ref #7750, ref #7740, ref #7697, ref #7619, ref #5619, ref #4030, ref #5278, ref #3302, ref #2524
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alerting/notifications Issues when sending alert notifications type/feature-request
Projects
None yet
Development

No branches or pull requests

3 participants