-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alerting: Fixing mobile notifications in Microsoft Teams #11484
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11484 +/- ##
==========================================
- Coverage 51.9% 51.85% -0.05%
==========================================
Files 359 359
Lines 26066 26058 -8
Branches 1509 1508 -1
==========================================
- Hits 13530 13513 -17
- Misses 11796 11803 +7
- Partials 740 742 +2 |
looks strange to have summary and title be the same (Is title shown in mobile notifications), should summary not use message when there is a message and some fallback like "NA" when no message (so no empty string). Is summary used in other clients? |
@torkelo Do you need anything else from me to get this PR merged? |
Thank you for contributing to Grafana! |
* master: (84 commits) docs: adds info about grafana-dev container changelog: add notes about closing #12282 Added Litre/min and milliLitre/min in Flow (#12282) remove papaparse dependency list name is deleteDatasources, not delete_datasources remove internal influx ifql datasource Document the endpoint for deleting an org tests: rewrite into table tests influxdb: adds mode func to backend changelog: add notes about closing #11484 changelog: add notes about closing #11233 Remove import Fix PR feedback Removed papaparse from external plugin exports Karma to Jest: query_builder dsproxy: move http client variable back Karma to Jest: threshold_mapper Expose react and slate to external plugins Karma to Jest: threshold_manager Karma to Jest: query_def, index_pattern ...
Apparently the summary field in a Microsoft Teams webhook request field gets used for the text displayed in mobile push notifications. If that field contains only whitespace the push notification displays the nonsensical text
Therefore this commit mirrors the notification title in the summary field.
It also removes the unsupported fields Mention and Recipient from the notifier data struct.