settings icons fix #11572
Merged
settings icons fix #11572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11572 +/- ##
=======================================
Coverage 51.9% 51.9%
=======================================
Files 359 359
Lines 26068 26068
Branches 1571 1571
=======================================
Hits 13530 13530
Misses 11796 11796
Partials 742 742 |
marefr
suggested changes
Apr 13, 2018
There was a problem hiding this comment.
Code looks good. Seem to be some inconsistencies regarding height of menu item/icon positioning. Seems like the permissions link is the only one higher than the others. Personally to me it looks like the versions and permissions icons not are aligned vertically with text. See screenshots below.
|
@marefr I know, the problem here is the fontawesome icon that has white space beneath it so it gets pushed up. I am not sure how to push it down. |
|
Tried to make it a little better: @bulletfactory @Ijin08 what do you think? |
marefr
approved these changes
Apr 16, 2018
ryantxu
added a commit
to NatelEnergy/grafana
that referenced
this pull request
Apr 18, 2018
* grafana/master: (52 commits) changelog: adds note for grafana#11173 changelog: fix typo changelog: notes about closing grafana#11572 Fix issues with metric reporting (grafana#11518) changelog: notes about closing grafana#10747 fix: Row state is now ignored when looking for dashboard changes (grafana#11608) disable codecov comments add some more sort order asserts for permissions store tests Revert "build: remove code cov" Revert "removes codecov from frontend tests" tsdb: update query and annotation editor help texts for postgres changelog: notes about closing grafana#11578 calculate datetime for timeFrom and timeTo macro in go set default for sslmode to verify-full in postgres datasource editor (grafana#11615) add some more sort order asserts for permissions store tests fix unconvert issues variable: fix binding bug after ts conversion add GetFromAsTimeUTC and GetToAsTimeUTC and use them in timeFilter macro fix merge conflict remove changes to module.ts from this branch ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added styling to fontawesome icons so they have same size as the other icons