Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshot: use given key and deleteKey #16876

Merged
merged 1 commit into from
May 9, 2019
Merged

Snapshot: use given key and deleteKey #16876

merged 1 commit into from
May 9, 2019

Conversation

zhulongcheng
Copy link
Contributor

Which issue(s) this PR fixes:
Fixes #16742

@zhulongcheng
Snapshot: use given key and deleteKey
87ae880 
Signed-off-by: zhulongcheng <zhulongcheng.me@gmail.com>
@torkelo
Copy link
Member

torkelo commented May 5, 2019

Don't think these 2 keys are supposed to be specified from the outside, they should always be generated.

@zhulongcheng
Copy link
Contributor Author

Should update the doc?

https://grafana.com/docs/http_api/snapshot/#create-new-snapshot

bergquist
bergquist approved these changes May 6, 2019
View reviewed changes
Copy link
Contributor

@bergquist bergquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making it possible to specify these keys could be good for an automation standpoint since URLs can be predictable. Many missing pieces to have a good workflow IMO but I dont see the harm in merging this.

@torkelo torkelo merged commit 7ebbeb0 into grafana:master May 9, 2019
@torkelo torkelo added this to the 6.3 milestone May 9, 2019
ryantxu added a commit to ryantxu/grafana that referenced this pull request May 9, 2019
@ryantxu
Merge remote-tracking branch 'grafana/master' into streaming
c68918c 
* grafana/master:
  plugins: fix how datemath utils are exposed to plugins (grafana#16976)
  NewDataSource: Updated page header title
  fix(prometheus): issue with click label to filter for recording rules in Explore
  Explore: Removes Promise.All from runQueries thunk (grafana#16957)
  Chore: Add prometheus basic auth proxy (grafana#16882)
  Snapshot: use given key and deleteKey (grafana#16876)
  DataSourcePlugins: more generics improvements (grafana#16965)
  AddDataSource: Updated page design & categories (grafana#16971)
  Templating: Support selecting all filtered values of multi-value variable (grafana#16873)
  Chore: Add Input stories (grafana#16897)
ryantxu added a commit to ryantxu/grafana that referenced this pull request May 9, 2019
@ryantxu
Merge remote-tracking branch 'grafana/master' into graph-with-series-…
72a48fc 
…data

* grafana/master:
  Changelog: Typo guage -> gauge (grafana#16982)
  TestData: stream via fetch (grafana#16963)
  plugins: fix how datemath utils are exposed to plugins (grafana#16976)
  NewDataSource: Updated page header title
  fix(prometheus): issue with click label to filter for recording rules in Explore
  Explore: Removes Promise.All from runQueries thunk (grafana#16957)
  Chore: Add prometheus basic auth proxy (grafana#16882)
  Snapshot: use given key and deleteKey (grafana#16876)
  DataSourcePlugins: more generics improvements (grafana#16965)
  AddDataSource: Updated page design & categories (grafana#16971)
  Templating: Support selecting all filtered values of multi-value variable (grafana#16873)
  Chore: Add Input stories (grafana#16897)
ryantxu added a commit to NatelEnergy/grafana that referenced this pull request May 9, 2019
@ryantxu
Merge remote-tracking branch 'grafana/master' into v6-circle-no-master
f10eaea 
* grafana/master: (40 commits)
  TableData: support name (grafana#16983)
  Changelog: Typo guage -> gauge (grafana#16982)
  TestData: stream via fetch (grafana#16963)
  plugins: fix how datemath utils are exposed to plugins (grafana#16976)
  NewDataSource: Updated page header title
  fix(prometheus): issue with click label to filter for recording rules in Explore
  Explore: Removes Promise.All from runQueries thunk (grafana#16957)
  Chore: Add prometheus basic auth proxy (grafana#16882)
  Snapshot: use given key and deleteKey (grafana#16876)
  DataSourcePlugins: more generics improvements (grafana#16965)
  AddDataSource: Updated page design & categories (grafana#16971)
  Templating: Support selecting all filtered values of multi-value variable (grafana#16873)
  Chore: Add Input stories (grafana#16897)
  FieldDisplay: Don't use group ui elements in field editors (grafana#16953)
  GettingStarted: Fixes layout issues, fixes grafana#16926 (grafana#16941)
  PanelModel: Fix crash after window resize, fixes grafana#16933 (grafana#16942)
  Singlestat: fixed centering issue for very small panels (grafana#16944)
  Tests: Adds end-to-end tests skeleton and basic smoke test scenario (grafana#16901)
  Chore: Replaces moment with Grafanas DateTime (grafana#16919)
  InfluxDB: Fix HTTP method should default to GET (grafana#16949)
  ...
ryantxu added a commit to NatelEnergy/grafana that referenced this pull request May 9, 2019
@ryantxu
Merge remote-tracking branch 'grafana/master' into v6-expose-emitter
54f02ea 
* grafana/master: (40 commits)
  TableData: support name (grafana#16983)
  Changelog: Typo guage -> gauge (grafana#16982)
  TestData: stream via fetch (grafana#16963)
  plugins: fix how datemath utils are exposed to plugins (grafana#16976)
  NewDataSource: Updated page header title
  fix(prometheus): issue with click label to filter for recording rules in Explore
  Explore: Removes Promise.All from runQueries thunk (grafana#16957)
  Chore: Add prometheus basic auth proxy (grafana#16882)
  Snapshot: use given key and deleteKey (grafana#16876)
  DataSourcePlugins: more generics improvements (grafana#16965)
  AddDataSource: Updated page design & categories (grafana#16971)
  Templating: Support selecting all filtered values of multi-value variable (grafana#16873)
  Chore: Add Input stories (grafana#16897)
  FieldDisplay: Don't use group ui elements in field editors (grafana#16953)
  GettingStarted: Fixes layout issues, fixes grafana#16926 (grafana#16941)
  PanelModel: Fix crash after window resize, fixes grafana#16933 (grafana#16942)
  Singlestat: fixed centering issue for very small panels (grafana#16944)
  Tests: Adds end-to-end tests skeleton and basic smoke test scenario (grafana#16901)
  Chore: Replaces moment with Grafanas DateTime (grafana#16919)
  InfluxDB: Fix HTTP method should default to GET (grafana#16949)
  ...
@adinhodovic adinhodovic mentioned this pull request Oct 21, 2019
Closed
@ying-jeanne ying-jeanne added the pr/external This PR is from external contributor label Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergquist bergquist bergquist approved these changes

Assignees
No one assigned
Labels
add to changelog pr/external This PR is from external contributor
Projects
None yet
Milestone
6.3.0-beta1
Development

Successfully merging this pull request may close these issues.

API does not use key or deleteKey when external is true
4 participants
@zhulongcheng @torkelo @bergquist @ying-jeanne