TimeSeries: Assume values are all numbers #18540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantxu
added
area/panel/data
torkelo
approved these changes
Aug 14, 2019
marefr
changed the title
marefr
pushed a commit
that referenced
this pull request
Aug 15, 2019
* assume number for TimeSeries types * use const (cherry picked from commit 0ba0772)
marefr
pushed a commit
that referenced
this pull request
Aug 15, 2019
* assume number for TimeSeries types * use const (cherry picked from commit 0ba0772)
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
Aug 15, 2019
* grafana/master: DataFrame: convert from row based to a columnar value format (grafana#18391) Packages: Temporarily skip canary releases if packages build fail (grafana#18577) Update latest.json to latest stable version (grafana#18575) Docs: Update changelog for v6.3.3 (grafana#18569) Graph: Fixed issue clicking on series line icon (grafana#18563) grafana/toolkit: Unpublish previous "next" version when releasing a new one (grafana#18552) Toolkit: write PR report to a folder with the circle build number (grafana#18560) CI: Fail build if yarn.lock is not up to date (grafana#18555) Chore: Updates react-dependant packages to address react warnings (grafana#18549) Prometheus: Fix regression of rerunning query on legend/interval change (grafana#18147) Explore/Prometheus: More consistently allows for multi-line queries (grafana#18362) Login: Fixes undefined redirect (grafana#18545) Plugins: expose react-redux, redux (grafana#18501) TimeSeries: assume values are all numbers (grafana#18540)
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
Aug 15, 2019
* grafana/master: DataFrame: convert from row based to a columnar value format (grafana#18391) Packages: Temporarily skip canary releases if packages build fail (grafana#18577) Update latest.json to latest stable version (grafana#18575) Docs: Update changelog for v6.3.3 (grafana#18569) Graph: Fixed issue clicking on series line icon (grafana#18563) grafana/toolkit: Unpublish previous "next" version when releasing a new one (grafana#18552) Toolkit: write PR report to a folder with the circle build number (grafana#18560) CI: Fail build if yarn.lock is not up to date (grafana#18555) Chore: Updates react-dependant packages to address react warnings (grafana#18549) Prometheus: Fix regression of rerunning query on legend/interval change (grafana#18147) Explore/Prometheus: More consistently allows for multi-line queries (grafana#18362) Login: Fixes undefined redirect (grafana#18545) Plugins: expose react-redux, redux (grafana#18501) TimeSeries: assume values are all numbers (grafana#18540)
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
Aug 15, 2019
* grafana/master: (156 commits) DataFrame: convert from row based to a columnar value format (grafana#18391) Packages: Temporarily skip canary releases if packages build fail (grafana#18577) Update latest.json to latest stable version (grafana#18575) Docs: Update changelog for v6.3.3 (grafana#18569) Graph: Fixed issue clicking on series line icon (grafana#18563) grafana/toolkit: Unpublish previous "next" version when releasing a new one (grafana#18552) Toolkit: write PR report to a folder with the circle build number (grafana#18560) CI: Fail build if yarn.lock is not up to date (grafana#18555) Chore: Updates react-dependant packages to address react warnings (grafana#18549) Prometheus: Fix regression of rerunning query on legend/interval change (grafana#18147) Explore/Prometheus: More consistently allows for multi-line queries (grafana#18362) Login: Fixes undefined redirect (grafana#18545) Plugins: expose react-redux, redux (grafana#18501) TimeSeries: assume values are all numbers (grafana#18540) Login: Angular to React (grafana#18116) InfoTooltip: Info icon with tooltip (grafana#18478) Annotations: Fix failing annotation query when time series query is cancelled (grafana#18532) remotecache: support SSL with redis (grafana#18511) QueryData: Handle that response data must be array (grafana#18504) React: Rename deprecated UNSAFE_componentWillReceiveProps (grafana#18526) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18479
If the field type is not set explicitly, DataFrame willl guess it from the name or first value. When the name is "time", it assumes a time type.
BUT with existing TimeSeries data, the value type should always be set to number