Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stackdriver: Add extra alignment period options #18909

Merged
merged 3 commits into from
Sep 13, 2019

Conversation

sunker
Copy link
Contributor

@sunker sunker commented Sep 5, 2019

As of now, the alignment period is not possible to enter manually by the user. Instead the user can choose between a range om alignment period options from a dropdown.

This PR adds a few extra alignment period options in the query editor dropdown. Also an upper boundry check for alignment period is removed in the backend. This is because the limitation does no longer exist in the stackdriver API.

Fixes #16739
Fixes #16738

Copy link
Contributor

@daniellee daniellee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniellee daniellee added this to the 6.4.0-beta1 milestone Sep 13, 2019
@daniellee daniellee merged commit 4c8f417 into master Sep 13, 2019
@daniellee daniellee deleted the add-alignment-period-options branch September 13, 2019 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants