Remove redundant condition checking of ROLE_VIEWER
#19211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
Sep 19, 2019
* grafana/master: (39 commits) LDAP: Show non-matched groups returned from LDAP (grafana#19208) plugins: expose whole rxjs to plugins (grafana#19226) SQL: Rewrite statistics query (grafana#19178) CI: Update frontend ci metrics for strict null checks grafana/ui: Add disabled prop on LinkButton (grafana#19192) Cloudwatch: Fix autocomplete for Gamelift dimensions (grafana#19145) (grafana#19146) Backend: Remove redundant condition of `ROLE_VIEWER` (grafana#19211) FieldDisplay: Update title variable syntax (grafana#19217) Docs: Note when using For and No Data in alert rule (grafana#19185) Docker: Upgrade packages to resolve reported vulnerabilities (grafana#19188) MSSQL: Revert usage of new connectionstring format (grafana#19203) Prometheus: datasource config with custom parameters string (grafana#19121) Contributing: Add guidelines for contributing docs (grafana#19108) LDAP debug page: deduplicate errors (grafana#19168) Menu: fix menu button in the mobile view (grafana#19191) Dashboard: Fixes back button styles in kiosk mode (grafana#19165) API: adds redirect helper to simplify http redirects (grafana#19180) docs: image rendering (grafana#19183) Chore: Update latest.json (grafana#19177) Chore: Update version to next (grafana#19169) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Removes redundant condition checking.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: