grafana/ui: Timezone picker #19364
Merged
grafana/ui: Timezone picker #19364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkelo
reviewed
Sep 24, 2019
| return group.options.find(option => option.value === value); | ||
| }); | ||
|
|
||
| console.log(selectedValue); |
torkelo
approved these changes
Sep 24, 2019
| ]; | ||
| }; | ||
|
|
||
| const europeZones = [ |
There was a problem hiding this comment.
Can you move these into the getTimeZoneGroups function so we do not need to create these arrays in global scope?
ryantxu
added a commit
that referenced
this pull request
Sep 24, 2019
* grafana/master: MySQL: Limit datasource error details returned from the backend (#19373) MySQL, Postgres: Update raw sql when query builder updates (#19209) MySQL, Postgres, MSSQL: Fix validating query with template variables in alert (#19237) Explore: Do not send explicit maxDataPoints for logs. (#19235) grafana/ui: Add Timezone picker (#19364) Heatmap: use DataFrame rather than LegacyResponseData (#19026) Explore: Refactor mode selection (#19356) Dashboard: Fix export for sharing when panels use default data source (#19315) Azure Monitor: Revert support for cross resource queries (#19115)" (#19346) grafana/ui: Add electrical units mAh and kAh (#19314) grafana/ui: Add Indian Rupee (INR) to currencies (#19201) Chore: Bump typescript to version 3.6.3 (#19308)
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
Sep 24, 2019
…uery * grafana/master: MySQL: Limit datasource error details returned from the backend (grafana#19373) MySQL, Postgres: Update raw sql when query builder updates (grafana#19209) MySQL, Postgres, MSSQL: Fix validating query with template variables in alert (grafana#19237) Explore: Do not send explicit maxDataPoints for logs. (grafana#19235) grafana/ui: Add Timezone picker (grafana#19364) Heatmap: use DataFrame rather than LegacyResponseData (grafana#19026) Explore: Refactor mode selection (grafana#19356) Dashboard: Fix export for sharing when panels use default data source (grafana#19315) Azure Monitor: Revert support for cross resource queries (grafana#19115)" (grafana#19346) grafana/ui: Add electrical units mAh and kAh (grafana#19314) grafana/ui: Add Indian Rupee (INR) to currencies (grafana#19201) Chore: Bump typescript to version 3.6.3 (grafana#19308) Explore: Refactor live tail controls (grafana#19328) Docs: Documentation for return-to-dashboard feature (grafana#19198) Select: Set placeholder color (grafana#19309) Keybindings: Improve esc / exit / blur logic (grafana#19320) Plugins: Skips existence of module.js for renderer plugins (grafana#19318) Explore: Fix unsubscribing from Loki websocket (grafana#19263)
hugohaggmark
pushed a commit
that referenced
this pull request
Oct 1, 2019
* first things and story * fixed data structure and fixed picker * remove console log * move variables into global scope (cherry picked from commit bb0a438)
hugohaggmark
pushed a commit
that referenced
this pull request
Oct 1, 2019
* first things and story * fixed data structure and fixed picker * remove console log * move variables into global scope (cherry picked from commit bb0a438)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a TimeZone picker.